-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define the fallback case for service.name #1269
Define the fallback case for service.name #1269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this is the wrong place to specify this. I mean, it's fine to additionally specify it here, but we need a list of required resources in the SDK specification. Maybe https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/resource/sdk.md, although in principle it applies to tracing, metrics and probably logging SDK.
I think we should not assume that SDK implementers will read all resource semantic conventions.
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Fair point. I think this documentation needs to be here, but we also need to mention this in the main |
We probably also want that for the telemetry.sdk resources BTW. |
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Based on this comment, #1241 (comment), I'm inclined to promote my own suggestion above: Explicitly, it means that we can remove some of the words in this PR and simply specify one of the two options in my comment. |
Just as a note, I think whatever the decision is here needs to be something that is obvious to an operator/consumer of the telemetry and something that is non-suitable for actual usage (such as a 'smart' derived name based on command line or whatnot). Ultimately the name of a service is a logical decision made by humans who are interpreting data, but if we're too clever about it, some users may defer to the cleverness which is good up until the moment it isn't. An obvious default that isn't suitable for long-term usage satisfies both of these conditions. |
The semantic conventions in https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/resource/semantic_conventions/process.md already contain the command name, and the telemetry SDK details are built in (https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/resource/semantic_conventions/README.md), so based on @austinlparker's comment I think when |
After a few iterations myself, I think we either go with:
Opinions? cc @yurishkuro @Oberon00 |
I prefer "unknown" to be in the name. I don't have a strong opinion on auto-resolvers, but I share Austin's concern with them not doing the right thing and being worse than the default. |
I support "unknown" |
Ping @Oberon00 (as I'm also slightly inclined to use |
"unknown" is fine. Or "unknown:EXE-NAME". |
Ping @Oberon00 @austinlparker |
lgtm |
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
I think there is awareness now for the problem with #1034, so not blocking this PR (trusting you to sort this out properly)
Fixes #1241, #1237
This is a very minimalistic clarification based on what currently many SIGs do (providing a fallback based on the running service), finally defaulting to the
unknown_service
literal.