Add k8s.node semantic convention #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm curious to learn the benefits of tracking Kubernetes Node in addition to Pods? Would you expect one or the other to be captured or both? |
|
Duplicate of #1341 ? |
Sorta but this also adds uid and that other one is stale. |
You may want to filter your metrics or spans by a kubernetes node name.
Would expect both. |
|
Thanks @jrcamp |
tigrannajaryan
approved these changes
Jan 29, 2021
bogdandrutu
approved these changes
Jan 29, 2021
arminru
approved these changes
Feb 1, 2021
|
@bogdandrutu can you merge? |
carlosalberto
approved these changes
Feb 3, 2021
XSAM
approved these changes
Feb 4, 2021
|
@jrcamp please resolve the conflict. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
k8s.nodesemantic convention to existing k8s conventions.