Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate entries for span limits env, because of the default changes #1427

Merged
merged 4 commits into from
Feb 11, 2021

Conversation

bogdandrutu
Copy link
Member

No description provided.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@jkwatson
Copy link
Contributor

I just noticed that the SDK section about SpanLimits still has 1000 as the defaults, rather than the 128 that the env vars specifies. Do you want to tweak that here, or should I put in a separate PR?

@bogdandrutu
Copy link
Member Author

bogdandrutu commented Feb 10, 2021

Yes bug :(. Please send a PR

@bogdandrutu
Copy link
Member Author

Rebase failed :)

@jkwatson
Copy link
Contributor

Yes bug :(. Please send a PR

#1429

@carlosalberto carlosalberto changed the title Invalidate entries for span limits env, because of the deault changes Invalidate entries for span limits env, because of the default changes Feb 11, 2021
@carlosalberto carlosalberto merged commit d89f446 into open-telemetry:main Feb 11, 2021
@bogdandrutu bogdandrutu deleted the invalidmatrix branch February 11, 2021 15:31
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…open-telemetry#1427)

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants