Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container runtime to container conventions #1482

Merged
merged 5 commits into from
Mar 2, 2021
Merged

Add container runtime to container conventions #1482

merged 5 commits into from
Mar 2, 2021

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Mar 1, 2021

This allows users to identify the engine and possible issues with the runtime when debugging.

This allows users to identify the engine and possible
issues with the runtime when debugging.
@arminru arminru added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory labels Mar 1, 2021
@rakyll
Copy link
Contributor Author

rakyll commented Mar 1, 2021

Addressed the feedback, please take a look.

@carlosalberto carlosalberto merged commit 7033091 into open-telemetry:main Mar 2, 2021
@arminru
Copy link
Member

arminru commented Mar 2, 2021

Actually it would probably be better to use an enum like we did elsewhere, for example here:

- id: provider
type:
allow_custom_values: true
members:
- id: AWS
value: 'aws'
brief: 'Amazon Web Services'
- id: Azure
value: 'azure'
brief: 'Microsoft Azure'
- id: GCP
value: 'gcp'
brief: 'Google Cloud Platform'
brief: >
Name of the cloud provider.
examples: 'gcp'

`cloud.provider` MUST be one of the following or, if none of the listed values apply, a custom value:
| Value | Description |
|---|---|
| `aws` | Amazon Web Services |
| `azure` | Microsoft Azure |
| `gcp` | Google Cloud Platform |

This will allow constant classes or helpers generated from the YAML definitions to provide constants for these well-known engines in order to ensure we always get the same values. If users have to provide the string values themselves, we will probably get crio in one case and CRI-O in another.
@rakyll Do you think this would make sense?

ThomsonTan pushed a commit to ThomsonTan/opentelemetry-specification that referenced this pull request Mar 30, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants