Introduce EKS cluster semantic conventions #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
added
area:semantic-conventions
arminru
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
I'm not familiar with EKS but this looks reasonable to me since k8s.cluster.name will likely not be sufficient to uniquely identify an EKS cluster.
@rakyll Please also add the new file/convention to the TOC in specification/resource/semantic_conventions/cloud_provider/aws/README.md.
|
Done, @arminru. PTAL. |
anuraaga
approved these changes
Mar 2, 2021
This change is a follow-up to #1098 and introduces EKS specific semantic conventions.
|
Conflict is resolved, this is good to merge. |
carlosalberto
approved these changes
Mar 8, 2021
ThomsonTan
pushed a commit
to ThomsonTan/opentelemetry-specification
that referenced
this pull request
Mar 30, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is a follow-up to #1098 and introduces EKS specific semantic conventions.