Ignore invalid spancontext in addLink #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
approved these changes
Mar 2, 2021
bogdandrutu
reviewed
Mar 2, 2021
|
@anuraaga thanks |
|
Assigned @bogdandrutu (assuming this is why @yurishkuro removed assignment? :P) |
iNikem
approved these changes
Mar 2, 2021
mateuszrzeszutek
approved these changes
Mar 2, 2021
carlosalberto
approved these changes
Mar 2, 2021
rakyll
approved these changes
Mar 3, 2021
|
@arminru Thanks updated changelog |
reyang
approved these changes
Mar 3, 2021
|
@open-telemetry/technical-committee Can this be merged? It has many approvals. |
yurishkuro
approved these changes
Mar 5, 2021
ThomsonTan
pushed a commit
to ThomsonTan/opentelemetry-specification
that referenced
this pull request
Mar 30, 2021
* Ignore invalid spancontext in addLink * SDK not API * Changelog Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds text that adding links should be ignored if the links are to an invalid spancontext. This seems like reasonable behavior.
Fixes #1486