Mention that semantic conventions should be autogenerated #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyll
changed the title
iNikem
approved these changes
Mar 9, 2021
arminru
reviewed
Mar 9, 2021
rakyll
commented
Mar 10, 2021
carlosalberto
approved these changes
Mar 17, 2021
SergeyKanzhelev
approved these changes
Mar 17, 2021
|
PR is good as is. It may be worth it to add the note about the way to expose these constant though |
anuraaga
reviewed
Mar 17, 2021
Adding a section to semantic conventions to capture the implementation requirementes from the languages. This is a follow up from the spec SIG model where we discussed we should ask each langauge to autogenerate the semantic conventions keys from the YAML files.
bogdandrutu
approved these changes
Mar 22, 2021
ThomsonTan
pushed a commit
to ThomsonTan/opentelemetry-specification
that referenced
this pull request
Mar 30, 2021
…etry#1515) * Mention that semantic conventions should be autogenerated Adding a section to semantic conventions to capture the implementation requirementes from the languages. This is a follow up from the spec SIG model where we discussed we should ask each langauge to autogenerate the semantic conventions keys from the YAML files. * Add to CHANGELOG * Fix CHANGELOG * Fix the link * markdownlint * Address feedback * Address feedback * Fix typ * Update overview.md Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com> Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a section to semantic conventions to capture the implementation
requirements from the languages.
This is a follow up from the spec SIG model where we
discussed we should ask each language to autogenerate
the semantic conventions keys from the YAML files.