-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestones proposal (clarification) #152
Milestones proposal (clarification) #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
milestones.md
Outdated
Milestones for Java and cross-language specification: | ||
|
||
- End of June: | ||
- basic SDK implemented in Java. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does "basic SDK" include support for logs?
- Mid September (or after end-user validation): | ||
- API is revised | ||
- End of September (or after end-user validation): | ||
- Version 1.0 is declared. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unclear that whether 1.0 will support logs or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If 1.0 doesn't cover logs, do we introduce logs in v2.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can introduce in 1.5 (random minor version) as long as we don't break compatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If library A is using v1.0 opentelemetry-api, application B uses library A and v1.5 opentelemetry-sdk, build would fail since the SDK cannot find the corresponding logging methods defined in the API package.
Technically this is solvable, we can discuss later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what language (linker) you are referring to. The way to resolve this is application B will enforce api & sdk with the same version (1.5) and the library A will happily use that because of backwards compatibility.
* milestones proposal * adjustments * added TLDR * missing semicolons * Update milestones.md * Update milestones.md * added links to the milestones
Resolves open-telemetry#1324 I believe changes to semantic conventions and the shape of emitted telemetry are likely to occur during the lifetime of an instrumentation library. I do not think we should aim to lock the telemetry schema and disallow changes to it. Such locking would place a huge limitation on how instrumentation can evolve and would make it nearly impossible to fix mistakes in the semantic conventions, in the schema or in the implementation of the instrumentation (which will inevitably happen sooner or later). This OTEP introduces the concept of telemetry schemas that allows semantic conventions and instrumentations to evolve over time without breaking consumers of telemetry.
Resolves open-telemetry#1324 I believe changes to semantic conventions and the shape of emitted telemetry are likely to occur during the lifetime of an instrumentation library. I do not think we should aim to lock the telemetry schema and disallow changes to it. Such locking would place a huge limitation on how instrumentation can evolve and would make it nearly impossible to fix mistakes in the semantic conventions, in the schema or in the implementation of the instrumentation (which will inevitably happen sooner or later). This OTEP introduces the concept of telemetry schemas that allows semantic conventions and instrumentations to evolve over time without breaking consumers of telemetry.
* milestones proposal * adjustments * added TLDR * missing semicolons * Update milestones.md * Update milestones.md * added links to the milestones
This proposal clarifies milestones of API revisions and SDK implementation. We are still shooting for a stable version of all project components in September and Sunset in November.
Milestones are quite aggressive to fit the desired goal.