Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define the fallback tracer name for invalid values. #1534

Merged
merged 10 commits into from
Mar 17, 2021
Merged

Define the fallback tracer name for invalid values. #1534

Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cf13824
Define the fallback tracer name for invalid values.
carlosalberto Mar 11, 2021
7471fed
Update specification/trace/api.md
carlosalberto Mar 11, 2021
9fcd5bb
Update specification/trace/api.md
carlosalberto Mar 11, 2021
65e1ae2
Merge branch 'main' into tracer_provider_invalid_name_case
carlosalberto Mar 15, 2021
8968238
Merge branch 'main' into tracer_provider_invalid_name_case
carlosalberto Mar 16, 2021
5a44a56
Update based on feedback.
carlosalberto Mar 17, 2021
ad4e4d4
Update CHANGELOG.
carlosalberto Mar 17, 2021
19a3c80
Update specification/trace/api.md
carlosalberto Mar 17, 2021
f71c6ff
Remove the mention of 'default' Tracer.
carlosalberto Mar 17, 2021
9b749f2
Merge branch 'main' into tracer_provider_invalid_name_case
carlosalberto Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions specification/trace/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,10 @@ This API MUST accept the following parameters:
In that scenario, the `name` denotes a module name or component name within that library
or application.
In case an invalid name (null or empty string) is specified, a working
default Tracer implementation as a fallback is returned rather than returning
null or throwing an exception.
default Tracer implementation MUST be returned as a fallback rather than returning
carlosalberto marked this conversation as resolved.
Show resolved Hide resolved
null or throwing an exception, and `name` SHOULD be the set to the
"`<INVALID INSTRUMENTATION NAME PROVIDED>`" literal, in order to signal that the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"`<INVALID INSTRUMENTATION NAME PROVIDED>`" literal, in order to signal that the
string `<INVALID INSTRUMENTATION NAME PROVIDED>`, in order to signal that the

specified value is invalid.
A library, implementing the OpenTelemetry API *may* also ignore this name and
return a default instance for all calls, if it does not support "named"
functionality (e.g. an implementation which is not even observability-related).
Expand Down