Clarify the TraceIdRatioBased description format #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samplers need to return a static string as a description. The string the TraceIdRatioBased sampler returns needs to be based on the sampling ratio that it is configured for. The current specification could be misinterpreted as requiring a static string that was not based on the samplers sampling ratio be used. This corrects that discrepancy.
arminru
approved these changes
Mar 12, 2021
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
carlosalberto
approved these changes
Mar 12, 2021
|
(Probably worth mentioning this in the maintainers meeting, for everybody is aware of this detail ;) ) |
iNikem
approved these changes
Mar 14, 2021
Co-authored-by: Nikita Salnikov-Tarnovski <gnikem@gmail.com>
ThomsonTan
pushed a commit
to ThomsonTan/opentelemetry-specification
that referenced
this pull request
Mar 30, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Samplers need to return a static string as a description. The string the TraceIdRatioBased sampler returns needs to be based on the sampling ratio that it is configured for. The current specification could be misinterpreted as requiring a static string that was not based on the samplers sampling ratio be used. This corrects that discrepancy.
Resolves #1524