Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update semantic conventions to distinguish between int and double #1550

Merged
merged 6 commits into from
Mar 18, 2021

Conversation

arminru
Copy link
Member

@arminru arminru commented Mar 16, 2021

This distinction was recently introduced in https://github.com/open-telemetry/build-tools/releases/tag/v0.3.0.
Note that the generic number type was dropped.

Fixes #1096.

@arminru arminru added the area:semantic-conventions Related to semantic conventions label Mar 16, 2021
@arminru arminru requested a review from a team as a code owner March 16, 2021 12:51
@arminru arminru requested review from a team March 16, 2021 12:51
@arminru arminru requested a review from a team as a code owner March 16, 2021 12:51
@arminru
Copy link
Member Author

arminru commented Mar 16, 2021

@anuraaga With this change you will be able to resolve #1422 (comment) since v0.3.0 allows you to define it as double.

@arminru arminru merged commit a44d863 into open-telemetry:main Mar 18, 2021
@arminru arminru deleted the semconv-number-int branch March 18, 2021 16:06
ThomsonTan pushed a commit to ThomsonTan/opentelemetry-specification that referenced this pull request Mar 30, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update YAML files for semantic conventions once supported by markdown generator
6 participants