Clarify B3 requirements and configuration #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Mar 23, 2021
yurishkuro
approved these changes
Mar 23, 2021
anuraaga
approved these changes
Mar 23, 2021
3 tasks
carlosalberto
approved these changes
Mar 23, 2021
bogdandrutu
reviewed
Mar 23, 2021
iNikem
approved these changes
Mar 23, 2021
bogdandrutu
approved these changes
Mar 23, 2021
rakyll
approved these changes
Mar 23, 2021
ThomsonTan
pushed a commit
to ThomsonTan/opentelemetry-specification
that referenced
this pull request
Mar 30, 2021
jkwatson
pushed a commit
to jkwatson/opentelemetry-java
that referenced
this pull request
Apr 14, 2021
…format. See this spec change from v1.2.0: open-telemetry/opentelemetry-specification#1570
anuraaga
pushed a commit
to open-telemetry/opentelemetry-java
that referenced
this pull request
Apr 14, 2021
…format. (#3154) See this spec change from v1.2.0: open-telemetry/opentelemetry-specification#1570
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1562
Changes
This PR updates the spec as discussed in #1562. It clarifies that b3 propagators for single and multi-header formats should extract both formats. The B3 single propagator should give precedence to b3 single when extracting, and inject using the single format only. Similarly, the B3 multi propagator should give precedence to b3 multi extracting and inject using only the multi format.