Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sum description in data model specification #1618

Merged
merged 17 commits into from
Apr 29, 2021

Conversation

jsuereth
Copy link
Contributor

Fixes #1566

Changes

  • Adds specification details around "Sum" and the semantics encoding in OTLP for sum
  • Clarifies "OTLP => Timeseries" mapping for Sum, Gauge + Histogram
  • Make sure "Summary" is described as legacy support
  • Outline algorithm for Delta=>Cumulative transformation, including limitations for accuracy.

@jsuereth jsuereth requested review from a team April 15, 2021 17:01
Co-authored-by: Eric Sirianni <sirianni@users.noreply.github.com>
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Show resolved Hide resolved
specification/metrics/datamodel.md Show resolved Hide resolved
jsuereth and others added 2 commits April 15, 2021 14:22
Co-authored-by: Punya Biswal <punya@google.com>
Co-authored-by: Punya Biswal <punya@google.com>
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jmacd
Copy link
Contributor

jmacd commented Apr 22, 2021

@open-telemetry/specs-metrics-approvers please take a look.

specification/metrics/datamodel.md Show resolved Hide resolved
@jsuereth
Copy link
Contributor Author

@jmacd This should be ready to go now.

@jmacd jmacd merged commit a4b08e2 into open-telemetry:main Apr 29, 2021
@jsuereth jsuereth deleted the wip-delta-to-cumulative branch April 29, 2021 14:22
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* Add Sum description in data model specification and outline delta-to-cumulative operation

* Update specification/metrics/datamodel.md

Co-authored-by: Eric Sirianni <sirianni@users.noreply.github.com>

* Fix verbage around summary.

* Update specification/metrics/datamodel.md

Co-authored-by: Punya Biswal <punya@google.com>

* Update specification/metrics/datamodel.md

Co-authored-by: Punya Biswal <punya@google.com>

* Clarify time window for sum.

* Update specification/metrics/datamodel.md

Co-authored-by: Reiley Yang <reyang@microsoft.com>

* Fix lint.

* crop all images

* Fix lint issue from merge

* Fixes from review.

* Add changelog, and address comments.

* Fix missing year.

Co-authored-by: Eric Sirianni <sirianni@users.noreply.github.com>
Co-authored-by: Punya Biswal <punya@google.com>
Co-authored-by: Reiley Yang <reyang@microsoft.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to rebuild from deltas?
8 participants