-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sum description in data model specification #1618
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cumulative operation
sirianni
reviewed
Apr 15, 2021
Co-authored-by: Eric Sirianni <sirianni@users.noreply.github.com>
jack-berg
reviewed
Apr 15, 2021
punya
reviewed
Apr 15, 2021
Co-authored-by: Punya Biswal <punya@google.com>
Co-authored-by: Punya Biswal <punya@google.com>
reyang
reviewed
Apr 15, 2021
Co-authored-by: Reiley Yang <reyang@microsoft.com>
jmacd
approved these changes
Apr 19, 2021
…/opentelemetry-specification into wip-delta-to-cumulative
reyang
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
victlu
reviewed
Apr 21, 2021
victlu
reviewed
Apr 21, 2021
@open-telemetry/specs-metrics-approvers please take a look. |
jmacd
approved these changes
Apr 26, 2021
bogdandrutu
approved these changes
Apr 27, 2021
@jmacd This should be ready to go now. |
victlu
approved these changes
Apr 28, 2021
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Add Sum description in data model specification and outline delta-to-cumulative operation * Update specification/metrics/datamodel.md Co-authored-by: Eric Sirianni <sirianni@users.noreply.github.com> * Fix verbage around summary. * Update specification/metrics/datamodel.md Co-authored-by: Punya Biswal <punya@google.com> * Update specification/metrics/datamodel.md Co-authored-by: Punya Biswal <punya@google.com> * Clarify time window for sum. * Update specification/metrics/datamodel.md Co-authored-by: Reiley Yang <reyang@microsoft.com> * Fix lint. * crop all images * Fix lint issue from merge * Fixes from review. * Add changelog, and address comments. * Fix missing year. Co-authored-by: Eric Sirianni <sirianni@users.noreply.github.com> Co-authored-by: Punya Biswal <punya@google.com> Co-authored-by: Reiley Yang <reyang@microsoft.com> Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1566
Changes