-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify usage of "otel." attribute namespace #1640
Clarify usage of "otel." attribute namespace #1640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections, but what practical impact (aside from being a warning) do you foresee here? Do we need some prescription of how to handle the non-spec attributes that start with otel.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me but I also wonder about the practical implications as Yuri already stated.
Also, please mention this change in the changelog.
OpenTelemetry specification. These are typically used to express OpenTelemetry | ||
concepts in formats that don't have a corresponding concept. | ||
|
||
For example `otel.library.name` attribute is used to record the instrumentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: I wonder if you can call that an attribute. This string will only appear in the Jager/Zipkin exporters at which point its debatable if this is an attribute or another kind of key/value pair.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is supposed to be recorded in the same map (tags in Jaeger vocabulary) where we record attributes. So, it occupies the same namespace of attribute names. I am not sure if there is a better term for this, I am open to suggestions.
We might define an optional collector filter that discards/warns about unknown |
Looks good to me! let's merge this once the feedback has been addressed ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, please resolve the comments :)
d67c878
to
41166d3
Compare
No other impact. Just a warning to prevent people from polluting "otel." namespace.
We do prescribe behavior for each individual attribute (e.g. One more thing we can do is to refactor the spec a bit and have all |
41166d3
to
07cc733
Compare
@tigrannajaryan I think we are ready to merge this. Could you add a CHANGELOG entry before we do so? |
I noticed developers adding their own attributes to this namespace without going through the specification. We need to regulate this namespace through the specification, just like we do it for other semantic conventions.
d5bae09
to
7991a05
Compare
Done. |
I noticed developers adding their own attributes to this namespace without going through the specification. We need to regulate this namespace through the specification, just like we do it for other semantic conventions.
I noticed developers adding their own attributes to this namespace
without going through the specification. We need to regulate this
namespace through the specification, just like we do it for other
semantic conventions.