Remove the "Func" name, use "Asynchronous" and "Observable" #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
requested review from
jkwatson,
jmacd,
jsuereth,
bogdandrutu and
aabmass
jkwatson
reviewed
Apr 26, 2021
tarekgh
approved these changes
Apr 26, 2021
jkwatson
reviewed
Apr 26, 2021
jkwatson
reviewed
Apr 26, 2021
jkwatson
reviewed
Apr 26, 2021
Co-authored-by: John Watson <jkwatson@gmail.com>
Co-authored-by: John Watson <jkwatson@gmail.com>
Co-authored-by: John Watson <jkwatson@gmail.com>
jsuereth
approved these changes
Apr 26, 2021
jonatan-ivanov
approved these changes
Apr 26, 2021
ebullient
approved these changes
Apr 27, 2021
jmacd
approved these changes
Apr 27, 2021
weyert
approved these changes
Apr 27, 2021
bogdandrutu
approved these changes
Apr 27, 2021
cijothomas
approved these changes
Apr 27, 2021
6 tasks
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…emetry#1645) * use the term Asynchronous/Observable instead of Func * call out that the ObservableCounter name has nothing to do with observer pattern * omit the return value from async instruments example code for now * Update specification/metrics/new_api.md Co-authored-by: John Watson <jkwatson@gmail.com> * Update specification/metrics/new_api.md Co-authored-by: John Watson <jkwatson@gmail.com> * Update specification/metrics/new_api.md Co-authored-by: John Watson <jkwatson@gmail.com> * rewrap Co-authored-by: John Watson <jkwatson@gmail.com> Co-authored-by: Bogdan Drutu <bogdandrutu@gmail.com> Co-authored-by: Sergey Kanzhelev <S.Kanzhelev@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #1617 (comment).
This has been discussed and concluded during the metrics API/SDK spec SIG meeting.
Changes