Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Histogram description to DataModel Specification #1664

Merged
merged 22 commits into from
May 13, 2021

Conversation

jsuereth
Copy link
Contributor

  • Adds Histogram description/meaning to data model specification
  • Describe meaning of Exemplars
  • Add a diagram for delta-histograms

Does not dive into bucketing strategies yes. This can be updated in the future.

@jsuereth jsuereth requested review from a team April 30, 2021 15:29
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: Reiley Yang <reyang@microsoft.com>
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
jsuereth and others added 5 commits May 3, 2021 10:05
@arminru arminru added area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory labels May 6, 2021
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
specification/metrics/datamodel.md Outdated Show resolved Hide resolved
jsuereth and others added 2 commits May 11, 2021 15:15
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
jsuereth and others added 2 commits May 11, 2021 15:16
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
@jmacd jmacd merged commit bc81e89 into open-telemetry:main May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:data-model For issues related to data model spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants