Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event semantic conventions, update semantic convention generator to v0.5.0 #1843

Merged
merged 9 commits into from
Sep 3, 2021

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Aug 3, 2021

This is a demo for open-telemetry/build-tools#57, which is in need of reviewers 😃 now merged

(also needs open-telemetry/build-tools#58)

Changes

  • Mark exception as semconv type "event" (default is span)
  • Add YAML definitions for grpc events.

@Oberon00 Oberon00 added area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory labels Aug 3, 2021
@Oberon00 Oberon00 requested review from a team August 3, 2021 16:17
.vscode/settings.json Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
semantic_conventions/trace/rpc.yaml Outdated Show resolved Hide resolved
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 13, 2021
@arminru
Copy link
Member

arminru commented Aug 17, 2021

@open-telemetry/specs-approvers / @open-telemetry/specs-trace-approvers Please also take a look at open-telemetry/build-tools#57 on which this change is based.

@github-actions github-actions bot removed the Stale label Aug 18, 2021
@Oberon00
Copy link
Member Author

As open-telemetry/build-tools#57 was merged, this now includes an update of the semantic convention generator to v0.5.0.

@Oberon00 Oberon00 changed the title Add event semantic conventions. Add event semantic conventions, update semantic convention generator to v0.5.0 Aug 24, 2021
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 1, 2021
@Oberon00
Copy link
Member Author

Oberon00 commented Sep 3, 2021

Sorry for being slow on this one, suggestion applied & conflicts resolved & build still green now!

@arminru arminru merged commit 32ca5a7 into open-telemetry:main Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants