Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple improvements to the Metrics SDK #1958

Merged
merged 9 commits into from
Sep 30, 2021
Merged

Multiple improvements to the Metrics SDK #1958

merged 9 commits into from
Sep 30, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Sep 22, 2021

Changes

  • Added concurrency/compatibilty requirements section in the Metrics SDK
  • Added MetricReader.Shutdown
  • Updated the ToC

@reyang reyang requested review from a team September 22, 2021 16:48
@reyang reyang added the spec:metrics Related to the specification/metrics directory label Sep 22, 2021
@reyang reyang added this to the Metrics API/SDK Feature Freeze milestone Sep 22, 2021
@reyang reyang added the area:sdk Related to the SDK label Sep 22, 2021
jmacd
jmacd approved these changes Sep 23, 2021
View reviewed changes
specification/metrics/sdk.md Outdated Show resolved Hide resolved
bogdandrutu
bogdandrutu reviewed Sep 29, 2021
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This is no longer "minor improvement", it is actually fixing some missing definitions and adds content for concurrency.

@jmacd
Copy link
Contributor

jmacd commented Sep 29, 2021

Looks good -- will you resolve the conflicts?

@carlosalberto
Copy link
Contributor

LGTM - reconsider adding the concurrency change in the CHANGELOG entry, btw.

@reyang reyang changed the title Minor improvements to the Metrics SDK Multiple improvements to the Metrics SDK Sep 30, 2021
@reyang
Copy link
Member Author

reyang commented Sep 30, 2021

LGTM - reconsider adding the concurrency change in the CHANGELOG entry, btw.

Done.

@carlosalberto carlosalberto merged commit 16da729 into open-telemetry:main Sep 30, 2021
@reyang reyang deleted the reyang/metrics-sdk-improvements branch September 30, 2021 15:57
@pirgeo pirgeo mentioned this pull request Nov 30, 2021
Closed
6 tasks
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@reyang
Multiple improvements to the Metrics SDK (open-telemetry#1958)
e0db34f 
* Added concurrency/compatibility requirements section in the Metrics SDK
* Added MetricReader.Shutdown
* Updated the ToC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu left review comments

@pirgeo pirgeo pirgeo approved these changes

@cijothomas cijothomas cijothomas approved these changes

@jmacd jmacd jmacd approved these changes

@hdost hdost hdost approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees

@carlosalberto carlosalberto

Labels
area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory
Projects
None yet
Milestone
Metrics API/SDK Feature Freeze
Development

Successfully merging this pull request may close these issues.
8 participants
@reyang @jmacd @carlosalberto @jsuereth @hdost @bogdandrutu @cijothomas @pirgeo