Clarify difference between container.name and k8s.container.name
#1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
clarify-container-name-difference
branch
2 times, most recently
from
51bf5c8
to
0b24e0e
Compare
Oberon00
reviewed
Sep 30, 2021
Oberon00
reviewed
Sep 30, 2021
Oberon00
added
area:semantic-conventions
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Oberon00
approved these changes
Oct 9, 2021
Add more details to container name attributes to clarify the difference.
dmitryax
force-pushed
the
clarify-container-name-difference
branch
from
bc185e9
to
9b312a2
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@open-telemetry/specs-approvers we need more reviews of this small change. |
bogdandrutu
approved these changes
Nov 4, 2021
|
Just clarifications, ok to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more details to container name attributes to clarify the difference.
Following from the thread in #1945