Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTracing section to the compliance matrix. #2046

Merged

Conversation

carlosalberto
Copy link
Contributor

As we are looking to stabilize the OpenTracing compatibility section, we want to keep track of the actual features in different SIGs.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@SergeyKanzhelev
Copy link
Member

@carlosalberto I've reassigned to you to move this forward as per e-mail from @bhs.

@carlosalberto
Copy link
Contributor Author

@yurishkuro Updated, please review - I'm keeping the Baggage support among execution units for now, while we decide whether we discard support for this or not.

@bhs
Copy link

bhs commented Nov 11, 2021

ping @carlosalberto on this (and @yurishkuro's comments)... this PR is on the critical path to formally archiving the OpenTracing project within CNCF so would be good to keep it moving, though obviously not P0 or anything. :)

@carlosalberto
Copy link
Contributor Author

@yurishkuro Applied feedback. The only remaining bit is the one regarding custom propagators - which is useful in case users want to use a different propagator for OpenTracing's HTTP_HEADERS and TEXT_MAP (by default we use the global OTel propagators for both types).

@carlosalberto
Copy link
Contributor Author

@yurishkuro Please review. Removed some parts (such as the Create Tracer with custom propagators) as they are already included in features that MUST be supported in their respective sections.

Left the error mapping one without a link as it is mentioned in both sections. It can probably be also removed though, although I'd personally keep that one in order to signal implementers of its importance ;)

Copy link
Contributor

@tedsuo tedsuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up Carlos.

@carlosalberto carlosalberto merged commit 43192ed into open-telemetry:main Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants