Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define "none" enum value #2102

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Define "none" enum value #2102

merged 2 commits into from
Nov 15, 2021

Conversation

pellared
Copy link
Member

@pellared pellared commented Nov 5, 2021

What

Define "none" as enum value used to set a null object (empty, no-op value).

Why

  1. Having a possibility to "disable" something via enum values when the default settings are "enabling" some feature is critical
  2. Enforce consistency

Addresses: #2045 (comment)

Related PRs:

@pellared pellared requested review from a team November 5, 2021 14:59
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 13, 2021
@carlosalberto
Copy link
Contributor

@tigrannajaryan @bogdandrutu please review

@jmacd jmacd merged commit 48ea76c into open-telemetry:main Nov 15, 2021
@pellared pellared deleted the patch-1 branch November 15, 2021 21:32
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants