-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
View aggregation examples modified to remove unsupported things #2305
View aggregation examples modified to remove unsupported things #2305
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like it to be clear how the reader should interpret the first argument of the reader. I want it to explain this is the treatment for synchronous instruments, which the SDK has control over. Asynchronous instruments should be exported in their natural temporality, and we do not want to encourage anyone to expect Cumulative-to-Delta conversion inside the SDK.
Don't think this example need to talk about it. There is spec already existing here https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#metricreader which talk about temporality, cumulative->delta conversions etc. |
Later in the SDK specification, we write:
But the reader will not have reached that point in the specification yet, and I want it to be clear what this means. I changed my suggestion from "using" to "preferring" which is more correct. |
See #2314 |
The current spec for View does not allow specifying temporality (cumulative/delta) on aggregation, and it is only allowed along with MetricReader. This PR is modifying the examples to remove the unsupported capabilities, to avoid confusion.