-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining Kafka and Kafka consumer metrics. #2536
Merged
reyang
merged 14 commits into
open-telemetry:main
from
carlosalberto:kafka-metrics-additional
May 26, 2022
Merged
Add remaining Kafka and Kafka consumer metrics. #2536
reyang
merged 14 commits into
open-telemetry:main
from
carlosalberto:kafka-metrics-additional
May 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
May 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
reyang
added
area:semantic-conventions
Related to semantic conventions
spec:metrics
Related to the specification/metrics directory
labels
May 13, 2022
mwear
approved these changes
May 13, 2022
jmacd
reviewed
May 17, 2022
specification/metrics/semantic_conventions/instrumentation/kafka.md
Outdated
Show resolved
Hide resolved
specification/metrics/semantic_conventions/instrumentation/kafka.md
Outdated
Show resolved
Hide resolved
specification/metrics/semantic_conventions/instrumentation/kafka.md
Outdated
Show resolved
Hide resolved
specification/metrics/semantic_conventions/instrumentation/kafka.md
Outdated
Show resolved
Hide resolved
specification/metrics/semantic_conventions/instrumentation/kafka.md
Outdated
Show resolved
Hide resolved
…ka.md Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
…ka.md Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
…ka.md Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
…ka.md Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Ping @dmitryax as original author/maintainer of the Kafka Metrics receiver. |
jmacd
approved these changes
May 24, 2022
Ping @dmitryax ;) |
beeme1mr
pushed a commit
to beeme1mr/opentelemetry-specification
that referenced
this pull request
Aug 31, 2022
carlosalberto
added a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:semantic-conventions
Related to semantic conventions
spec:metrics
Related to the specification/metrics directory
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #2485 - this time adding the Kafka & Kafka consumer metrics from Kafka Metrics Receiver
I'd like to suggest a few changes:
consumer_group
in the name is changed toconsumer
(to match theproducer
metrics format)..brokers
becomes UpDownCounter.topic.partitions
becomes UpDownCounter.replicas
becomes.replicas.all
and UpDownCounter.replicas_in_sync
becomes.replicas.in-sync
and UpDownCounter.members
becomes UpDownCountercc @mwear @jmacd