Allow recording links only at Span creation time #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
requested review from
AloisReitbauer,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
songy23
approved these changes
Sep 24, 2019
carlosalberto
approved these changes
Sep 24, 2019
yurishkuro
approved these changes
Sep 24, 2019
Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
Co-Authored-By: Yang Song <songy23@users.noreply.github.com>
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Allow recording links only at Span creation time Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Fix grammar for attributes during span creation Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update specification/api-tracing.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com> * Update specification/api-tracing.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com> * Fix some links to the add-links
TuckTuckFloof
pushed a commit
to TuckTuckFloof/opentelemetry-specification
that referenced
this pull request
Oct 15, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 23, 2024
…ion (open-telemetry#258) Based on conversations last week in the Specification and Semantic Conventions SIGs, I'm opening this duplicate pull request which was originally set as a [Draft](https://github.com/open-telemetry/oteps/pull/241/files) and hasn't had movement since last November. There are real use cases that are coming to fruiting, namely in the CI/CD working group, that will benefit from this being accepted. Once accepted we can work on getting the specification added for both general context propagation and baggage. On the note of baggage; baggage is a form of context propagation and was not originally mentioned directly by name in this OTEP. It is however, absolutely essential. I've had the pleasure of prototyping out tracing within an OpenTofu controller system where context on available in parent/child at the very start of the trace was available. Baggage was the means of transferring this critical context to subsequent siblings that would've not had it otherwise. Thanks for all the hard work to the original author (@deejgregor) and opening the draft open-telemetry#241 CC. TC sponsors @jsuereth @carlosalberto --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Allow recording links only at Span creation time Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Fix grammar for attributes during span creation Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> * Update specification/api-tracing.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com> * Update specification/api-tracing.md Co-Authored-By: Yang Song <songy23@users.noreply.github.com> * Fix some links to the add-links
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…ion (open-telemetry#258) Based on conversations last week in the Specification and Semantic Conventions SIGs, I'm opening this duplicate pull request which was originally set as a [Draft](https://github.com/open-telemetry/oteps/pull/241/files) and hasn't had movement since last November. There are real use cases that are coming to fruiting, namely in the CI/CD working group, that will benefit from this being accepted. Once accepted we can work on getting the specification added for both general context propagation and baggage. On the note of baggage; baggage is a form of context propagation and was not originally mentioned directly by name in this OTEP. It is however, absolutely essential. I've had the pleasure of prototyping out tracing within an OpenTofu controller system where context on available in parent/child at the very start of the trace was available. Baggage was the means of transferring this critical context to subsequent siblings that would've not had it otherwise. Thanks for all the hard work to the original author (@deejgregor) and opening the draft open-telemetry#241 CC. TC sponsors @jsuereth @carlosalberto --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove addLink support from the Span API and allow only during Span creation.
For more details about why see https://github.com/open-telemetry/oteps/blob/master/text/0006-sampling.md#links