Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move non-otlp.md to common directory #2587

Merged

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented May 27, 2022

Many of the rules specified in non-otlp.md apply to all signals,
not just to traces.

The common directory is a better place for this file. Also renamed
the file to mapping-to-non-otlp.md to better reflect the content.

Fixes #2578.

@tigrannajaryan tigrannajaryan requested review from a team May 27, 2022 16:34
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arminru arminru added the spec:protocol Related to the specification/protocol directory label May 31, 2022
specification/common/mapping-to-non-otlp.md Outdated Show resolved Hide resolved
Many of the rules specified in non-otlp.md apply to all signals,
not just to traces.

The common directory is a better place for this file. Also renamed
the file to mapping-to-non-otlp.md to better reflect the content.
@reyang reyang merged commit 9abbdd3 into open-telemetry:main Jun 2, 2022
@tigrannajaryan tigrannajaryan deleted the feature/tigran/move-nonotlp branch June 2, 2022 20:29
beeme1mr pushed a commit to beeme1mr/opentelemetry-specification that referenced this pull request Aug 31, 2022
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:protocol Related to the specification/protocol directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move generic content non-otlp.md to non-trace specific directory
4 participants