Config option enabling exponential histogram as default histogram aggregation #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
Jun 16, 2022
4 tasks
jmacd
approved these changes
Jun 16, 2022
reyang
reviewed
Jun 17, 2022
reyang
reviewed
Jun 17, 2022
pirgeo
reviewed
Jun 20, 2022
arminru
reviewed
Jun 21, 2022
arminru
approved these changes
Jun 22, 2022
This was referenced Jun 23, 2022
beeme1mr
pushed a commit
to beeme1mr/opentelemetry-specification
that referenced
this pull request
Aug 31, 2022
beeme1mr
pushed a commit
to beeme1mr/opentelemetry-specification
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2471.
opentelemetry-java has an exponential histogram implementation, but its currently quite obscure / difficult to use because the exponential histograms aren't yet stable in the spec. As discussed in #2471 and #2429, we removed the "best available histogram" aggregation anticipating later adding an option like this to make it easy for users to opt in to exponential histograms. I'd like to add the configuration option now so that opentelemetry-java users can more easily use exponential histograms, and provide any feedback needed to stabilization of the specification.