Clarify SpanExporter#ForceFlush is required #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
approved these changes
Jul 8, 2022
jmacd
approved these changes
Jul 8, 2022
carlosalberto
approved these changes
Jul 11, 2022
arminru
added
area:sdk
arminru
reviewed
Jul 12, 2022
arminru
approved these changes
Jul 12, 2022
jsuereth
approved these changes
Jul 12, 2022
reyang
reviewed
Jul 13, 2022
| The exporter must support two functions: **Export** and **Shutdown**. In | ||
| strongly typed languages typically there will be 2 separate `Exporter` | ||
| The exporter MUST support three functions: **Export**, **Shutdown**, and **ForceFlush**. | ||
| In strongly typed languages typically there will be 2 separate `Exporter` |
There was a problem hiding this comment.
Not blocking, maybe we can just remove this sentence? It mentioned metrics in a tracing spec (also it might be inaccurate because LogExporter does exist https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/logging-library-sdk.md#logexporter).
reyang
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2652
Changes