-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the HTTP client http.retry_count
spec
#2743
Clarify the HTTP client http.retry_count
spec
#2743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra examples and for better formatting them :)
I just have a question on naming. The attribute is retry
but in the text we use the word re-send/sent
. Not sure if it's a problem but I wonder if we shouldn't be consistent?
I'm in favor of this idea; initially I didn't want to change too much of the spec, just clarify things, but if more people than just me think it's a valid point I think we could rename it to |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@open-telemetry/specs-approvers @open-telemetry/technical-committee please take a look at this PR cc @lmolkova (sorry, I completely forgot to tag you before 🙈) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @mateuszrzeszutek!
cb03fab
to
da61ca0
Compare
Sorry, forgot to hit send in one comment: You probably need to add an entry to the changelog for this as well, otherwise looks good to me. |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
/unstale |
de052b6
to
0e0f782
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
560a1d3
to
4a448db
Compare
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
4a448db
to
69b20f0
Compare
Ping @open-telemetry/technical-committee : is this PR ready to be merged? Is there anything else that I can help with? |
Fixes #2737
Changes
Clarifies when the
http.retry_count
attribute should be added to the HTTP client span (every time the HTTP request gets re-sent, no matter what the cause is).I also added a grouping "Examples" header for all examples, similar to other (messaging, DB) convention docs.