Rename built-in ExemplarFilters #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsuereth PTAL. Thanks.! |
reyang
reviewed
Nov 4, 2022
reyang
reviewed
Nov 4, 2022
lalitb
approved these changes
Nov 10, 2022
cijothomas
changed the title
jsuereth
reviewed
Nov 11, 2022
There was a problem hiding this comment.
I'm ok aiming for consistency, but two questions raised -
- Will this be confusing to users
- Should we be doing renames during feature-freeze? This causes churn / could break an SDK that has the feature implemented. Just want to check impact before making that change.
jmacd
reviewed
Nov 17, 2022
jsuereth
approved these changes
Nov 18, 2022
jack-berg
approved these changes
Nov 21, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
reyang
reviewed
Nov 29, 2022
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Reopening as it seems this was briefly forgotten, but has enough approvals to be merged. @cijothomas please consider addressing the latest bits so we can merge this ;) |
|
@reyang @jack-berg @jsuereth Please do a final check. "TraceBased" suggestion is done, and also added changelog. |
Done! |
jack-berg
approved these changes
Dec 12, 2022
jmacd
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the built-in ExemplarFilters to AlwaysOn, AlwaysOff, TraceBased. (inspired from the built-in samplers in trace spec)
Minor clarification about ExemplarFilters, that they only make measurements eligible for being Exemplars.
Fix links:
Currently, the set of built-in ExemplarFilters are not documented in the SDK page, but user is taken to a link, which takes to yet another link, which lists the available ExemplarFilters. This PR adds the built-in filter details in the SDK page itself, instead of only being documented in the environment variable page.