Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define data ownership for LogRecordProcessor #2969

Merged
merged 6 commits into from
Dec 2, 2022
Merged

Define data ownership for LogRecordProcessor #2969

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0916bb0
Define data ownership for LogRecordProcessor
jack-berg Nov 21, 2022
8ca8c2e
Remove ownership phrasing, incorporate feedback
jack-berg Nov 30, 2022
27592a5
Merge branch 'main' of https://github.com/open-telemetry/opentelemetr…
jack-berg Nov 30, 2022
fccf659
Add changelog entry
jack-berg Nov 30, 2022
588e75f
Merge branch 'main' into log-processor-data-ownership
jack-berg Dec 1, 2022
bba6177
Merge branch 'main' into log-processor-data-ownership
jack-berg Dec 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ release.
([#2940](https://github.com/open-telemetry/opentelemetry-specification/pull/2940))
- Split out Event API from Log API
([#2941](https://github.com/open-telemetry/opentelemetry-specification/pull/2941))
- Clarify data modification in `LogRecordProcessor`.
([#2969](https://github.com/open-telemetry/opentelemetry-specification/pull/2969))

### Resource

Expand Down
4 changes: 4 additions & 0 deletions specification/logs/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,10 @@ therefore it SHOULD NOT block or throw exceptions.

**Returns:** `Void`

A `LogRecordProcessor` may freely modify `logRecord` for the duration of
the `OnEmit` call. If `logRecord` is needed after `OnEmit` returns (i.e. for
asynchronous processing) only reads are permitted.

#### ShutDown

Shuts down the processor. Called when the SDK is shut down. This is an
Expand Down