Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[semantic_conventions/resource] fix google platform openshift naming #3095

Merged
merged 4 commits into from
Jan 23, 2023
Merged

[semantic_conventions/resource] fix google platform openshift naming #3095

merged 4 commits into from
Jan 23, 2023

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Jan 11, 2023

Fixes #3090

Changes

Please provide a brief description of the changes here.

Rename google openshift platform attribute.

@frzifus frzifus requested review from a team January 11, 2023 14:59
@arminru arminru added area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory labels Jan 12, 2023
@arminru arminru requested review from jsuereth and a team January 12, 2023 10:34
joaopgrassi
joaopgrassi approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I guess this also needs a changelog entry? Since the values changed 🤔

@frzifus frzifus force-pushed the fix_openshift_platform_name branch 2 times, most recently from 8777b51 to 9874851 Compare January 12, 2023 14:48
@frzifus
Copy link
Member Author

frzifus commented Jan 12, 2023

Looks good to me. I guess this also needs a changelog entry? Since the values changed thinking

Fair point. Added a changelog entry 👍

@frzifus
[semantic_conventions/resource] fix google platform openshift naming
0886946 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus
changelog: fix linting
93e3fee 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus
Copy link
Member Author

frzifus commented Jan 16, 2023 •
edited
Loading

hm.. i wonder if thats simply needs a re-run. https://github.com/open-telemetry/opentelemetry-specification/actions/runs/3932225377/jobs/6724514011#step:4:237

update, it fails locally too.

FILE: ./specification/metrics/semantic_conventions/system-metrics.md
  [✖] https://web.archive.org/web/20180321091318/http://www.onlamp.com/pub/a/linux/2000/11/16/LinuxAdmin.html

  22 links checked.

  ERROR: 1 dead links found!
  [✖] https://web.archive.org/web/20180321091318/http://www.onlamp.com/pub/a/linux/2000/11/16/LinuxAdmin.html → Status: 0
make: *** [Makefile:31: markdown-link-check] Fehler 1

@carlosalberto
Copy link
Contributor

cc @jsuereth

@frzifus
Copy link
Member Author

frzifus commented Jan 23, 2023

any update here?

@carlosalberto
Copy link
Contributor

Maybe @dashpole can confirm?

dashpole
dashpole approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me, and in-line with other naming. It isn't a GCP product, obviously, but that also applies to aws_openshift and azure_openshift.

@reyang reyang merged commit 0835b71 into open-telemetry:main Jan 23, 2023
@frzifus frzifus deleted the fix_openshift_platform_name branch January 24, 2023 09:25
@frzifus frzifus mentioned this pull request May 21, 2024
Open
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@frzifus
[semantic_conventions/resource] fix google platform openshift naming (o…
4522df3 
…pen-telemetry#3095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@arminru arminru arminru approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@MrAlias MrAlias MrAlias approved these changes

@dashpole dashpole dashpole approved these changes

@jsuereth jsuereth Awaiting requested review from jsuereth

Assignees

@jsuereth jsuereth

Labels
area:semantic-conventions Related to semantic conventions spec:resource Related to the specification/resource directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid openshift platform name in semconv 1.16.0
8 participants
@frzifus @carlosalberto @dashpole @MrAlias @joaopgrassi @arminru @reyang @jsuereth