Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mention of net.transport from http semantic conventions #3244

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Remove mention of net.transport from http semantic conventions #3244

merged 4 commits into from
Feb 28, 2023

Conversation

trask
Copy link
Member

@trask trask commented Feb 22, 2023

Based on @lmolkova's #3215 (comment)

Changes

Removes mention of net.transport from http semantic conventions.

@trask trask marked this pull request as ready for review February 22, 2023 01:35
@trask trask requested review from a team February 22, 2023 01:35
@lmolkova lmolkova mentioned this pull request Feb 22, 2023
Closed
@arminru arminru added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory semconv:HTTP labels Feb 28, 2023
@jsuereth jsuereth merged commit 583719a into open-telemetry:main Feb 28, 2023
@trask trask deleted the remove-transport-attr-from-http branch February 28, 2023 21:21
@mateuszrzeszutek mateuszrzeszutek mentioned this pull request Apr 28, 2023
Merged
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@trask @reyang
Remove mention of net.transport from http semantic conventions (open-…
37c42cb 
…telemetry#3244)

Based on @lmolkova's
open-telemetry#3215 (comment)

## Changes

Removes mention of `net.transport` from http semantic conventions.

---------

Co-authored-by: Reiley Yang <reyang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@reyang reyang reyang approved these changes

@pyohannes pyohannes pyohannes approved these changes

@arminru arminru arminru approved these changes

@lmolkova lmolkova lmolkova approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees

@jsuereth jsuereth

Labels
area:semantic-conventions Related to semantic conventions semconv:HTTP spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@trask @jsuereth @lmolkova @arminru @pyohannes @reyang @mateuszrzeszutek