Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare OTLP stable #3274

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Conversation

jonatan-ivanov
Copy link
Member

Since OTLP/JSON was declared stable, all the parts of the OTLP spec is stable so the whole spec should be declared as such
See gh-2930

@jonatan-ivanov jonatan-ivanov requested review from a team March 2, 2023 18:23
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should move the "Stable" tag from individual sections?

@jsuereth
Copy link
Contributor

jsuereth commented Mar 2, 2023

Can you also remove the "status" callouts in subsections since the whole document is marked stable?

@jonatan-ivanov
Copy link
Member Author

👍🏼 I also removed the signal maturity level section.

Copy link
Contributor

@carlosalberto carlosalberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this changes as, I think, there are some last conditions before we can declare OTLP stable as a whole: open-telemetry/opentelemetry-proto#400

@tigrannajaryan would you mind taking a look? Discard this changes request otherwise.

@jonatan-ivanov
Copy link
Member Author

@carlosalberto Might worth putting a line or two in OTLP spec about why it is not stable yet if all of its components are declared as stable.

@tigrannajaryan
Copy link
Member

This should be fine, I don't see anything that remains experimental.

Let's not rush it though and give us time to think through.

A question: do we have sufficiently clear understanding of what "Stable" means for this document or we need to spell it out explicitly?

Since OTLP/JSON was declared stable, all the parts of the OTLP spec is stable
so the whole spec should be declared as such
See open-telemetrygh-2930

Signed-off-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>
@jonatan-ivanov
Copy link
Member Author

@tigrannajaryan Can you bring this up in the next spec meeting to see what others think?

@carlosalberto
Copy link
Contributor

@jonatan-ivanov Oh, definitely.

@reyang reyang merged commit b290f35 into open-telemetry:main Mar 8, 2023
lmolkova pushed a commit to lmolkova/opentelemetry-specification that referenced this pull request Mar 8, 2023
@jonatan-ivanov jonatan-ivanov deleted the declare-otlp-stable branch March 8, 2023 20:47
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants