Ensure logs bridge API doesn't contain implementation details #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
force-pushed
the
log-api-vs-sdk
branch
from
2983ba0
to
a31221e
Compare
jack-berg
changed the title
jack-berg
commented
Mar 2, 2023
jack-berg
commented
Mar 2, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
jsuereth
approved these changes
Mar 16, 2023
|
@open-telemetry/specs-logs-approvers please review. |
tigrannajaryan
approved these changes
Mar 24, 2023
reyang
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3268.
@MrAlias did some good work in the metrics API / SDK recently in #3171 and #3067 to ensure that the metrics API spec doesn't contain SDK implementation details.
This PR adopts similar language in the Logs Bridge API / SDK documents, which includes breaking out a
noop.mddocument.