Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify duplicate instrument registration scope to be a MeterProvider #3538

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Clarify duplicate instrument registration scope to be a MeterProvider #3538

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfbd2cd
Scope the duplicate instrument reg to a MeterProvider
MrAlias Jun 5, 2023
7b55783
Merge branch 'main' into scope-dupe-inst-mp
MrAlias Jun 9, 2023
ee253e4
Merge branch 'main' into scope-dupe-inst-mp
MrAlias Jun 26, 2023
397e37f
Merge branch 'main' into scope-dupe-inst-mp
MrAlias Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,10 +658,10 @@ Distinct meters MUST be treated as separate namespaces for the purposes of detec
### Duplicate instrument registration

When more than one Instrument of the same `name` is created for identical
Meters, denoted _duplicate instrument registration_, the Meter MUST create a
valid Instrument in every case. Here, "valid" means an instrument that is
functional and can be expected to export data, despite potentially creating a
[semantic error in the data
Meters from the same MeterProvider, denoted _duplicate instrument
registration_, the Meter MUST create a valid Instrument in every case. Here,
"valid" means an instrument that is functional and can be expected to export
data, despite potentially creating a [semantic error in the data
model](data-model.md#opentelemetry-protocol-data-model-producer-recommendations).

It is unspecified whether or under which conditions the same or
Expand Down