Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how log appender use Scope name and attributes #3583

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Clarify how log appender use Scope name and attributes #3583

merged 4 commits into from
Aug 1, 2023

Conversation

tigrannajaryan
Copy link
Member

@tigrannajaryan tigrannajaryan commented Jul 5, 2023 •
edited
Loading

Resolves #3562

Resolves #2358

I moved the recommendations for appenders to a separate file named supplementary-guidelines.md. Similar to other signals this file will contain non-normative recommendations.

@tigrannajaryan tigrannajaryan requested review from a team July 5, 2023 17:12
@tigrannajaryan
Clarify how log appender use Scope name and attributes
bd87bfc 
Resolves open-telemetry#3562

I moved the recommendations for appenders to a separate
file named supplementary-guidelines.md. Similar to other
signals this file will contain non-normative recommendations.
@tigrannajaryan
Copy link
Member Author

I think this also resolves #2358

@Oberon00
Copy link
Member

Oberon00 commented Jul 7, 2023

supplementary-guidelines is a separate top-level directory at the moment. I'd suggest to keep the location of supplementary guidelines consistent (though personally I prefer the way of this PR).

@tigrannajaryan
Copy link
Member Author

supplementary-guidelines is a separate top-level directory at the moment. I'd suggest to keep the location of supplementary guidelines consistent (though personally I prefer the way of this PR).

We have the exact same approach for metrics, with supplementary-guidelines.md file a sibling of the api file: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/supplementary-guidelines.md

The directly you refer to is for "other" stuff that does not fit in the signals' directories.

@carlosalberto carlosalberto mentioned this pull request Jul 10, 2023
Open
@carlosalberto
Copy link
Contributor

Let's discuss the supplementary guidelines location in #3587 instead (not a blocker for this PR).

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 18, 2023
@tigrannajaryan
Copy link
Member Author

@open-telemetry/specs-logs-approvers please review.

jack-berg
jack-berg approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small text change, but this is more appropriate as a supplementary guideline 👍

specification/logs/supplementary-guidelines.md Outdated Show resolved Hide resolved
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 26, 2023
arminru
arminru reviewed Jul 28, 2023
View reviewed changes
specification/logs/supplementary-guidelines.md Outdated Show resolved Hide resolved
specification/logs/supplementary-guidelines.md Outdated Show resolved Hide resolved
specification/logs/supplementary-guidelines.md Outdated Show resolved Hide resolved
specification/logs/supplementary-guidelines.md Outdated Show resolved Hide resolved
@arminru

This comment was marked as resolved.

Sign in to view
@arminru
Copy link
Member

arminru commented Jul 31, 2023

@tigrannajaryan fyi https://status.lfx.dev/incidents/ssyv13fbdprf

@tigrannajaryan
Copy link
Member Author

/easycla

@arminru arminru merged commit 19ca392 into open-telemetry:main Aug 1, 2023
6 checks passed
@tigrannajaryan tigrannajaryan deleted the feature/tigran/log-guidelines branch August 1, 2023 15:27
@tigrannajaryan tigrannajaryan mentioned this pull request Aug 1, 2023
Closed
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@tigrannajaryan @arminru
Clarify how log appender use Scope name and attributes (open-telemetr…
d5a4a93 
…y#3583)

Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg approved these changes

@arminru arminru arminru approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

Assignees

@jmacd jmacd

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@tigrannajaryan @Oberon00 @carlosalberto @arminru @jack-berg @jmacd