Revise the exemplar default reservoirs #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it normative that an SDK is recommended to include both types of default reservoirs. Make the description of both default reservoirs their own sub-sections. Correct the "SimpleExemplarReservoir" section to be titled "SimpleFixedSizeExemplarReservoir". Loosen the SimpleFixedSizeExemplarReservoir to allow any uniformly-weighted sampling algorithm instead of just the naive one that is not optimal.
MrAlias
force-pushed
the
exemplar-res-default
branch
from
06b14ce
to
37485e9
Compare
cijothomas
reviewed
Jul 27, 2023
cijothomas
approved these changes
Jul 27, 2023
reyang
approved these changes
Jul 27, 2023
jsuereth
approved these changes
Jul 28, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
- Make it normative that an SDK is recommended to include both types of default reservoirs. - Make the description of both default reservoirs their own sub-sections. - Correct the "SimpleExemplarReservoir" section to be titled "SimpleFixedSizeExemplarReservoir". - Loosen the SimpleFixedSizeExemplarReservoir to allow any uniformly-weighted sampling algorithm instead of just the naive one that is not optimal. - The current algorithm has an asymptotic running time of `O(n)`. There are other sampling algorithms that produce equivalent results and have more optimal asymptotic running times. Therefore, do not restrict implementations to only implementing the inefficient algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O(n). There are other sampling algorithms that produce equivalent results and have more optimal asymptotic running times. Therefore, do not restrict implementations to only implementing the inefficient algorithm.