logs: Document Flags mapping in Google Cloud logs appendix #3629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damemi
force-pushed
the
gcp-logs-flags-issampled
branch
from
5b78342
to
dd8828d
Compare
damemi
force-pushed
the
gcp-logs-flags-issampled
branch
from
dd8828d
to
e0cbbcd
Compare
dashpole
reviewed
Jul 28, 2023
dashpole
approved these changes
Jul 28, 2023
jsuereth
approved these changes
Aug 1, 2023
arminru
added
spec:logs
arminru
approved these changes
Aug 1, 2023
jack-berg
approved these changes
Aug 4, 2023
reyang
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GCP logging exporters should support the IsSampled flag, for example GoogleCloudPlatform/opentelemetry-operations-go#690 adds this support.
Currently, this is supported by the
gcp.trace_sampledattribute (by way of our mapping for "All other fields" to a matchinggcp.*attribute).Therefore, in the spec this is a breaking change (from
gcp.trace_sampledtoFlags), but implementations can continue to support the attribute for backward-compatibility.CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary