Fix description of OTEL_ATTRIBUTE_COUNT_LIMIT #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OTEL_ATTRIBUTE_COUNT_LIMIT variable was described in the SDK environment variables document as the "maximum allowed _span_ attribute count" (emphasis added). The "span" in that sentence was likely a mistake, since this variable applies to attributes in general, and not only to span attributes. These are more appropriately controlled with the OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT, which is probably where this description was accidentally copied from.
arminru
added
editorial
arminru
approved these changes
Oct 5, 2023
jack-berg
approved these changes
Oct 5, 2023
reyang
approved these changes
Oct 5, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The OTEL_ATTRIBUTE_COUNT_LIMIT variable was described in the SDK environment variables document as the "maximum allowed span attribute count" (emphasis added). The "span" in that sentence was likely a mistake, since this variable applies to attributes in general, and not only to span attributes. These are more appropriately controlled with the OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT, which is probably where this description was accidentally copied from.
This is a trivial change, so it follows the expedited process.