-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add definition for standard output logging exporter #3741
Merged
carlosalberto
merged 7 commits into
open-telemetry:main
from
codeboten:codeboten/add-stdout-exporters-logs
Nov 20, 2023
Merged
add definition for standard output logging exporter #3741
carlosalberto
merged 7 commits into
open-telemetry:main
from
codeboten:codeboten/add-stdout-exporters-logs
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the mostly a copy of the metrics standard output exporter definition but for the logging signal. Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
pushed a commit
to codeboten/opentelemetry-specification
that referenced
this pull request
Oct 26, 2023
This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it. Signed-off-by: Alex Boten <aboten@lightstep.com>
1 task
MrAlias
approved these changes
Oct 30, 2023
pellared
approved these changes
Nov 7, 2023
arminru
reviewed
Nov 7, 2023
I'll keep my comments on #3740 and assume that whatever we do over for the span version of the exporter will be mirrored for logs. |
arminru
reviewed
Nov 10, 2023
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Don't think the deadlink is caused by this change
|
jack-berg
approved these changes
Nov 17, 2023
pellared
approved these changes
Nov 20, 2023
codeboten
pushed a commit
to codeboten/opentelemetry-specification
that referenced
this pull request
Nov 21, 2023
This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it. Signed-off-by: Alex Boten <aboten@lightstep.com>
carlosalberto
pushed a commit
that referenced
this pull request
Nov 27, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
) ## Changes I couldn't find the definition for a standard output exporter for the logging signal, so I'm submitting one. This is mostly a copy of the definition already present for the metrics exporter. It doesn't specify a format for the output itself. Similar to open-telemetry#3740
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…#3742) ## Changes This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I couldn't find the definition for a standard output exporter for the logging signal, so I'm submitting one. This is mostly a copy of the definition already present for the metrics exporter. It doesn't specify a format for the output itself.
CHANGELOG.md
file updated for non-trivial changesSimilar to #3740