Clarifications and "flexibility" fixes in Exemplar Specification #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitial reservoir fill.
- Update fixed-size defaults to account for memory contention/optimisation. - Fix open-telemetry#3674: Set a default for exponential histograms.
- Make it clear that one reservoir is created PER timeseries point. - Allow flexibility in Reservoir definition, based on feedback from Go SIG - open-telemetry#3669
MrAlias
approved these changes
Nov 10, 2023
jack-berg
approved these changes
Nov 14, 2023
cijothomas
reviewed
Nov 14, 2023
cijothomas
reviewed
Nov 14, 2023
dashpole
approved these changes
Nov 14, 2023
jmacd
reviewed
Nov 17, 2023
jmacd
approved these changes
Nov 17, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
dashpole
reviewed
Nov 28, 2023
Co-authored-by: David Ashpole <dashpole@google.com>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…n-telemetry#3760) Fixes open-telemetry#2205 Fixes open-telemetry#3674 Fixes open-telemetry#3669 Partially fixes open-telemetry#2421 ## Changes - Update example exemplar algorithm to account for initial reservoir fill - Update fixed-size defaults to account for memory contention / optimization in Java impl - Set a default for exponential histogram aggregation - Clarify that ExemplarFilter should be configured on MeterProvider - Make it clear that ONE reservoir is create PER timeseries datapoint (not one reservoir per view or metric name). - Allow flexibility in Reservoir `offer` definition based on feedback from Go impl. * Related issues open-telemetry#3756 --------- Co-authored-by: David Ashpole <dashpole@google.com> Co-authored-by: Joshua MacDonald <jmacd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2205
Fixes #3674
Fixes #3669
Partially fixes #2421
Changes
offerdefinition based on feedback from Go impl.