Use *Data proto messages for file exporter #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
approved these changes
Jan 9, 2024
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
tigrannajaryan
approved these changes
Jan 9, 2024
carlosalberto
approved these changes
Jan 10, 2024
|
Waiting until tomorrow, if no objections will merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2390
Changes
The
*Requestproto messages are design for RPC/REST communication (request, response style) and may contain in the future information specific to this type of communication.The
*Dataproto messages are design for cases where only the telemetry data must be encoded without ony OTLP specific metadata.