-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize synchronous gauge #4019
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Apr 29, 2024
trask
approved these changes
Apr 29, 2024
pichlermarc
approved these changes
Apr 29, 2024
MrAlias
approved these changes
Apr 29, 2024
cijothomas
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
cc @open-telemetry/specs-metrics-approvers PTAL. |
8 tasks
Merged
carlosalberto
added a commit
that referenced
this pull request
May 9, 2024
4 tasks
MrAlias
added a commit
to open-telemetry/opentelemetry-go
that referenced
this pull request
May 16, 2024
Resolve #5225 The specification has [added a synchronous gauge instrument](open-telemetry/opentelemetry-specification#3540). That instrument has now been [stabilized](open-telemetry/opentelemetry-specification#4019), and that stabilization is included in the [next release](open-telemetry/opentelemetry-specification#4034). This adds the new synchronous gauge instrument to the metric API and all implementation we publish. This change will be a breaking change for any SDK developer. The `embedded` package is updated to ensure our compatibility guarantees are meet. --------- Co-authored-by: David Ashpole <dashpole@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:api
Cross language API specification issue
spec:metrics
Related to the specification/metrics directory
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3893.