Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify semantic conventions around span start and end time #592

Merged
merged 6 commits into from
Jun 30, 2020
Merged

Clarify semantic conventions around span start and end time #592

merged 6 commits into from
Jun 30, 2020

Commits on May 9, 2020

  1. Adding http semantic conventions for span start and end times.

    @toumorokoshi
    toumorokoshi committed May 9, 2020
    Configuration menu
    Copy the full SHA
    115ee37 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2020

  1. Corrected send to end, further clarified timings.

    @toumorokoshi
    toumorokoshi committed May 10, 2020
    Configuration menu
    Copy the full SHA
    bae0b66 View commit details
    Browse the repository at this point in the history

  2. Moving span operation clarification to api 

    Feedback states that the clarification around the meaning of the
span start and end times could be more generic. Starting a proposal
around by adding an example to the API.
    @toumorokoshi
    toumorokoshi committed May 10, 2020
    Configuration menu
    Copy the full SHA
    4dfa80d View commit details
    Browse the repository at this point in the history

Commits on May 16, 2020

  1. Addressing feedback 

    Rewording recommendation to use a more generic RPC

Adding a small blurb clarifying sub operations can be instrumented.
    @toumorokoshi
    toumorokoshi committed May 16, 2020
    Configuration menu
    Copy the full SHA
    8099078 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
Co-authored-by: Christian Neumüller <christian+github@neumueller.me>
    @toumorokoshi @arminru @Oberon00
    3 people committed May 19, 2020
    Configuration menu
    Copy the full SHA
    64b1ce4 View commit details
    Browse the repository at this point in the history

  2. Expanding on child spans

    @toumorokoshi
    toumorokoshi committed May 19, 2020
    Configuration menu
    Copy the full SHA
    43331f4 View commit details
    Browse the repository at this point in the history