Adapt semantic conventions for the span name of messaging systems #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
added
area:semantic-conventions
Oberon00
reviewed
Jul 7, 2020
…f the suggested span name format is used
Oberon00
reviewed
Jul 7, 2020
Oberon00
previously approved these changes
Jul 7, 2020
yurishkuro
reviewed
Jul 7, 2020
Oberon00
reviewed
Jul 8, 2020
Oberon00
reviewed
Jul 8, 2020
Oberon00
dismissed
their stale review
Mostly not sure about temporary destination being under Conversation
jmacd
reviewed
Jul 8, 2020
Oberon00
approved these changes
Jul 9, 2020
Oberon00
reviewed
Jul 10, 2020
…e nor conversation ID are suitable
arminru
force-pushed
the
messaging-span-name
branch
from
091498c
to
d742494
Compare
arminru
changed the title
Oberon00
reviewed
Jul 14, 2020
Oberon00
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
Quite some back and forth (mostly forth 😃, thank you @yurishkuro!) here, I think it looks good now. General guideline updates for span names (only use input from config+code) should be done separately.
yurishkuro
reviewed
Jul 14, 2020
yurishkuro
approved these changes
Jul 14, 2020
anuraaga
approved these changes
Jul 15, 2020
Oberon00
reviewed
Jul 15, 2020
codeboten
pushed a commit
to codeboten/opentelemetry-specification
that referenced
this pull request
Jul 20, 2020
…en-telemetry#690) * Adapt messaging semantic conventions to include the operation in the span name * Specify that the operation name must match the respective attribute if the suggested span name format is used * Update span names in examples * Consolidate definition of operation names into a separate section * Consolidate capitalization * Reference Conversation ID definition * Consolidate MD syntax * Organize definitions * Organize definitions * Reference definitions * Allow artificial destinations as span name if neither destination name nor conversation ID are suitable * Do not use conversation IDs for span name * Wording Co-authored-by: Christian Neumüller <christian.neumueller@dynatrace.com> * Fix typo * Add more links and guidance on messaging.operation * Fix changelog Co-authored-by: Christian Neumüller <christian.neumueller@dynatrace.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #686.