Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close stale PRs #744

Merged
merged 4 commits into from
Aug 3, 2020
Merged

Close stale PRs #744

merged 4 commits into from
Aug 3, 2020

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Jul 27, 2020

As discussed during today's maintainers meeting, this PR adds stale bot to the specification repo to close stale PRs.

For now I suggest running it in debug mode, without actually closing PRs. In a few days, when I verify it seems to be working (testing in production FTW), I will submit second PR removing debug mode.

@iNikem iNikem requested a review from a team as a code owner July 27, 2020 17:35
@carlosalberto carlosalberto added the area:miscellaneous For issues that don't match any other area label label Jul 27, 2020
@yurishkuro
Copy link
Member

Please elaborate on the motivation of this. Stale bots are useful to add impartiality to closing old issues that nobody is interested in solving. Is that the only intention here, or are you trying to achieve some other goals with the stale bot?

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@iNikem
Copy link
Contributor Author

iNikem commented Jul 28, 2020

@yurishkuro We have 33 PRs in this repo right now. The majority of them opened more than a month ago. Lots of them have not seen any activity for several weeks. This is an enormous amount of WIP and a huge waste. Stale bot will, hopefully, serve as a friendly nudge first, labelling stale PR and making comment there to bring author/reviewers attention to it. And if this does not help moving PR forward, then it will reduce the clutter in the PR list and mental load by closing it.

One can consult meeting notes as well.

Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
.github/workflows/state-pr.yaml Outdated Show resolved Hide resolved
Co-authored-by: Armin Ruech <armin.ruech@dynatrace.com>
@iNikem
Copy link
Contributor Author

iNikem commented Jul 29, 2020

@open-telemetry/specs-approvers Can this PR be now merged?

@iNikem
Copy link
Contributor Author

iNikem commented Jul 30, 2020

@open-telemetry/specs-approvers @open-telemetry/technical-committee Can this PR be now merged?

@carlosalberto carlosalberto merged commit ea15a2d into open-telemetry:master Aug 3, 2020
@carlosalberto
Copy link
Contributor

(I have a few doubts it will help, but let's give it a run, and we will see how it goes ;) )

@iNikem iNikem deleted the stale-bot branch August 3, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:miscellaneous For issues that don't match any other area label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants