Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up R/W span spec. #756

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Clean up R/W span spec. #756

merged 2 commits into from
Aug 5, 2020

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Aug 3, 2020

Follow-up to #669 (comment)

Changes

  • Adds a SHOULD requirement that for spans passed to OnStart, updates should be reflected.
  • Makes the convoluted definitions of read/write and readable span easier to read.

@Oberon00 Oberon00 requested review from a team August 3, 2020 14:10
@Oberon00 Oberon00 changed the title Cleanup R/W span spec. Clean up R/W span spec. Aug 3, 2020
@Oberon00 Oberon00 added area:sdk Related to the SDK spec:trace Related to the specification/trace directory labels Aug 3, 2020
@carlosalberto carlosalberto merged commit 66a6dc6 into open-telemetry:master Aug 5, 2020
@Oberon00 Oberon00 deleted the cleanup-rw-span branch December 18, 2020 10:59
@Oberon00 Oberon00 mentioned this pull request Apr 7, 2021
Closed
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@Oberon00
Clean up R/W span spec. (open-telemetry#756)
08a445f 
* Cleanup R/W span spec.

* Wording.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

Assignees
No one assigned
Labels
area:sdk Related to the SDK spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oberon00 @carlosalberto @bogdandrutu