Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify event timestamp origin and range #839

Merged
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
bb1e233
Document that event timestamps might be out of range
arminru Aug 20, 2020
fcbc5fe
Add to changelog
arminru Aug 20, 2020
8ded9fa
Update specification/trace/api.md
arminru Aug 20, 2020
c5ff2f3
Clarify that custom timestamps should only be used when necessary
arminru Aug 20, 2020
8f17b7f
Generalize occasions when timestamps might be out of range
arminru Aug 20, 2020
d5ba3bb
Point out that a timestamp is always there but can be overriden by th…
arminru Aug 20, 2020
d0f6e62
Remove inconsistent required/optional from property list
arminru Aug 21, 2020
4b44694
Merge branch 'master' into define-timestamp-range
arminru Aug 21, 2020
a3122b2
Merge branch 'master' into define-timestamp-range
arminru Aug 24, 2020
e3db762
Merge branch 'master' into define-timestamp-range
arminru Aug 24, 2020
fbaf199
Merge branch 'master' into define-timestamp-range
arminru Aug 25, 2020
bcc1b72
Merge branch 'master' into define-timestamp-range
arminru Aug 25, 2020
e329bbe
Merge branch 'master' into define-timestamp-range
arminru Aug 27, 2020
5d779f7
Merge branch 'master' into define-timestamp-range
arminru Aug 27, 2020
62b2dcc
Merge branch 'master' into define-timestamp-range
arminru Aug 28, 2020
9b684c9
Merge branch 'master' into define-timestamp-range
arminru Sep 2, 2020
3461fa2
Merge branch 'master' into define-timestamp-range
arminru Sep 3, 2020
548b655
Merge branch 'master' into define-timestamp-range
arminru Sep 8, 2020
2c45fef
Merge branch 'master' into define-timestamp-range
arminru Sep 9, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ Updates:
* SpanProcessors must provide read/write access at least in OnStart.
- Specify how `Probability` sampler is used with `ParentOrElse` sampler.
- Clean up api-propagators.md, by extending documentation and removing redundant sections ([#577](https://github.com/open-telemetry/opentelemetry-specification/pull/577))
- Document that event timestamps might be out of range ([#839](https://github.com/open-telemetry/opentelemetry-specification/pull/839))
arminru marked this conversation as resolved.
Show resolved Hide resolved

## v0.6.0 (07-01-2020)

Expand Down
6 changes: 6 additions & 0 deletions specification/trace/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,12 @@ The Span interface MUST provide:
Events SHOULD preserve the order in which they're set. This will typically match
the ordering of the events' timestamps.
arminru marked this conversation as resolved.
Show resolved Hide resolved

Consumers should be aware that an event's timestamp might be before the start or
after the end of the span if such timestamp was provided by the user to the
arminru marked this conversation as resolved.
Show resolved Hide resolved
`AddEvent` API.
The specification does not require any normalization if the provided timestamp
is out of this range.

Note that the OpenTelemetry project documents certain ["standard event names and
keys"](semantic_conventions/README.md) which have prescribed semantic meanings.

Expand Down