Add semantic conventions for outgoing FaaS invocations #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
added
area:semantic-conventions
carlosalberto
approved these changes
Aug 24, 2020
arminru
commented
Aug 25, 2020
Comment on lines
67
to
69
| | `faas.invoked_name` | string | The name of the invoked function. | `my-function` | Yes | | ||
| | `faas.invoked_provider` | string | The cloud provider of the invoked function. | `aws` | Yes | | ||
| | `faas.invoked_region` | string | The cloud region of the invoked function. | `eu-central-1` | See below | |
There was a problem hiding this comment.
I'm inviting y'all to a naming/namespacing discussion! 😀
Please vote:
🎉 - faas.invoked_name, faas.invoked_provider, faas.invoked_region
🚀 - faas.invoked.name, faas.invoked.provider, faas.invoked.region (introducing a separate invoked namespace)
👀 - the above, but with outgoing instead of invoked
😕 - something else
There was a problem hiding this comment.
I think invoked is fine. I would weakly prefer a namespace probably, but I have no real reason other than "feels right".
Oberon00
reviewed
Aug 25, 2020
Oberon00
approved these changes
Aug 26, 2020
Oberon00
reviewed
Aug 26, 2020
anuraaga
reviewed
Aug 26, 2020
tigrannajaryan
approved these changes
Aug 27, 2020
thisthat
approved these changes
Sep 1, 2020
dyladan
approved these changes
Sep 2, 2020
|
@arminru please rebase. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #861.