-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table summarizing sampler properties and processing #871
Merged
yurishkuro
merged 22 commits into
open-telemetry:master
from
cijothomas:cijothomas/sdksamper1
Aug 26, 2020
Merged
Changes from 9 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ddcc2d7
Add table summarizing sampler properties and processing
cijothomas 03d6d70
markdownlink
cijothomas 29a4a91
Merge branch 'master' into cijothomas/sdksamper1
cijothomas 66d1620
event -> data to avoid confusion with Event
cijothomas 62aed50
events -> data
cijothomas 3de6f46
plural
cijothomas 0b625c8
use MUST
cijothomas 7c7f265
Update specification/trace/sdk.md
cijothomas 36b83c5
Update specification/trace/sdk.md
cijothomas 686969e
reword
cijothomas 9452678
spacing
cijothomas bbad7aa
more links fix
cijothomas f77ffdd
markdownl
cijothomas fbfe97d
Merge branch 'master' into cijothomas/sdksamper1
cijothomas 5d92a46
Update specification/trace/sdk.md
cijothomas 6ce78c8
Merge branch 'master' into cijothomas/sdksamper1
cijothomas 8dbcc78
Merge branch 'master' into cijothomas/sdksamper1
cijothomas 94e9bb4
Merge branch 'master' into cijothomas/sdksamper1
yurishkuro 455b600
Merge branch 'master' into cijothomas/sdksamper1
cijothomas 29fab81
Merge branch 'master' into cijothomas/sdksamper1
carlosalberto e9ca916
Merge branch 'master' into cijothomas/sdksamper1
cijothomas c241b1d
Merge branch 'master' into cijothomas/sdksamper1
yurishkuro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "in memory data"? I think the current wording (== the old wording) is more clear here. What would be more clear IMHO would be:
and remove the "otherwise ...".